Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): hide sidebar after click on child item #2649

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Apr 23, 2020

Motivation

Resolve #2647

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Test on v2 website

  1. In config file add a new new child item of nav that belongs to the same sidebar, for example:
    navbar: {
    // ...
      links: [
        {
          label: 'Docs',
          items: [
            {
              label: 'First item',
              to: 'docs/design-principles',
            },
            {
              label: 'Second item',
              to: 'docs/introduction',
            },
  1. Run dev server

  2. Click alternately on the first and second items - the sidebar should close.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Apr 23, 2020
@lex111 lex111 added this to the v2.0.0-alpha.51 milestone Apr 23, 2020
@lex111 lex111 requested review from wgao19 and yangshun as code owners April 23, 2020 07:09
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 23, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 219430d

https://deploy-preview-2649--docusaurus-2.netlify.app

@yangshun yangshun merged commit 796bd0c into master Apr 23, 2020
@lex111 lex111 deleted the lex111/close-dropdown branch April 23, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nav sidebar fail to hide after clicking its second level content
4 participants